feat: Allow specifying extension of declaration files #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lachlancollins
added a commit
to TanStack/config
that referenced
this pull request
Jan 1, 2024
lachlancollins
added a commit
to TanStack/config
that referenced
this pull request
Jan 3, 2024
* feat: Add vite build config export * Fix exports * Add declaration * Fix prettier * Add react integration * Add CJS test * Add documentation * Update deps * Update tsconfig.json and docs * Remove duplicated deps * Update docs * Add more src files to react integration * Add vue integration * Add vue snapshot * Disable declarationMap until dtsExtension added to vite-plugin-dts See: qmhc/vite-plugin-dts#292 * Update integration snapshots * docs: Update vite instructions
|
I'm closing this because I found a workaround using I don't think it will work with declaration maps, but it's a reasonable solution for my use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
This allows you to replace the
.d.tsextension with one of your liking (e.g..d.cts,.d.mts) by passing in thedtsExtensionoption.If not set, it does nothing. If set, it changes where declarations and declaration maps get written, updates the
"file"field in the declaration map, and updates thesourceMappingURLfield in the declaration.I found it was incompatible with
rollupTypes: true, so it will not run if it finds this is enabled. Making that compatible would require a more extensive refactor.This solves needing to use an
afterBuildfunction to rename file extensions.