Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/public apt #2291

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Ci/public apt #2291

merged 6 commits into from
Nov 22, 2024

Conversation

zerg-su
Copy link
Contributor

@zerg-su zerg-su commented Nov 22, 2024

Referenced issues

Add support for APT package installation for KAGOME releases.
Refactor get_version.sh to support sanitized versioning.

Description of the Change

  • Description of the Change:
  • This pull request introduces several updates and improvements across the repository:

APT Package Installation Documentation:

  • Added step-by-step instructions in the README.md for installing KAGOME via APT on Ubuntu 24.04.1 LTS (Noble Numbat).
  • Provided detailed commands for adding the GPG signing key, configuring the repository, and installing KAGOME packages.

Updates to get_version.sh:

  • Added a --sanitized flag to generate sanitized version strings.
  • Improved script readability and ensured compatibility with various shell environments.

Docker Build Improvements:

  • Updated Makefile to include support for sanitized versioning during Docker builds.
  • Enhanced APT package upload logic to differentiate between internal and public repositories for release builds.

Build Scripts Enhancements:

  • Modified build_apt_package.sh to ensure artifacts are copied using cp instead of mv for better debugging and artifact retention.
  • Updated control file generation and added relevant metadata for Ubuntu packaging.

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

@zerg-su zerg-su enabled auto-merge (squash) November 22, 2024 08:37
@zerg-su zerg-su merged commit a38eb0b into master Nov 22, 2024
12 checks passed
@zerg-su zerg-su deleted the ci/public_apt branch November 22, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants