-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why do we need checkRow function? #2017
Comments
The library pre-allocates some consecutive cells for set cell value randomly. Please reference the documentation to using stream mode API (stream writer for generate worksheet, and rows iterator for reading worksheet) to reduce memory usage. |
I tried using a Stream Reader (rows) and StreamW riter, but since the Stream Reader only returns an array of string values (without cell style), I cannot use them to maintain the style when writing. |
There are no plan to change for the prepareCell recently, I dont think that use a loop to find the cell instead of accessing it directly by index can be reduce memory usage without much more time cost, if you'd like to create a pull request for this to improvement performance, that's would be great. |
Description
This function consumes too much memory, and I don't see the benefit of filling gap columns for rows.
Let's examine the GetColumnCell function:
You are looping through the columns and checking the cell name to return a value.
Therefore, what is the purpose of filling gap columns here?
The text was updated successfully, but these errors were encountered: