Change ESSL colorisation approach #3021

gerritholl · 2024-12-18T15:55:53Z

Change the approach for ESSL colorisation. Remove the dedicated class and instead define a colourmap to be used with the colorize enhancement. Fix the ratio to be the right way around.

Fixes and closes 3020.

Added an image comparison test for low level moisture over Mali. Because it uses the same instrument (Meteosat-12) as the ones added in #3013, added a column for what scene we are looking at (a simple text label) to the behave tests.

Closes Re-implement essl_colorized_low_level_moisture using colorize #3020
Tests added.

Change the approach for ESSL colorisation. Remove the dedicated class and instead define a colourmap to be used with the colorize enhancement. Fix the ratio to be the right way around. Fixes and closes 3020.

codecov · 2024-12-18T16:03:17Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (92b9719) to head (cc850ab).
Report is 76 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3021      +/-   ##
==========================================
- Coverage   96.11%   96.10%   -0.01%     
==========================================
  Files         383      381       -2     
  Lines       55604    55544      -60     
==========================================
- Hits        53443    53383      -60     
  Misses       2161     2161

Flag	Coverage Δ
behaviourtests	`3.89% <ø> (-0.02%)`	⬇️
unittests	`96.20% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coveralls · 2024-12-18T16:16:11Z

Pull Request Test Coverage Report for Build 12831451262

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 96.214%

Totals
Change from base Build 12829518226:	-0.005%
Covered Lines:	53629
Relevant Lines:	55739

💛 - Coveralls

mraspaud · 2025-01-08T07:52:25Z

Thanks for the PR! Can we have a before/after image comparison?

Change standard_name back to name in the enhancement, or satpy won't find the correct enhancement and won't use it.

gerritholl · 2025-01-08T08:26:19Z

Before :

After:

We see a difference only in the noise part at night, probably because the ratio is defined the other way around.

gerritholl

start behave test

gerritholl

start behave test

gerritholl

start behave test

gerritholl

start behave test

gerritholl

start behave test

gerritholl

start behave test

gerritholl

start behave test

gerritholl

start behave test

gerritholl

start behave test

rymdulf · 2025-01-17T16:21:42Z

Starting to clone and test the repository pytroll/satpy

rymdulf · 2025-01-17T16:25:48Z

The testing process was executed successfully. See the test results for this pull request here!

gerritholl · 2025-01-17T16:32:22Z

For the image comparison tests, night_microphysics shows differences, but that's also true for main, as #3013 was merged like that 🙈

There are also 24 pixels in low level moisture that are different (out of 575280), probably because I calculated the reference image on a different machine and there are rounding differences.

mraspaud · 2025-01-20T10:24:46Z

For the image comparison tests, night_microphysics shows differences, but that's also true for main, as #3013 was merged like that 🙈

There are also 24 pixels in low level moisture that are different (out of 575280), probably because I calculated the reference image on a different machine and there are rounding differences.

Something you want to fix in this PR?

mraspaud

LGTM!
"No code is better than no code"

gerritholl · 2025-01-20T10:43:26Z

Something you want to fix in this PR?

No. Night microphysics for FCI needs more discussion. And the 24 pixels in low level moisture are below the threshold, rounding differences are allowed.

Change ESSL colorisation approach

982a31c

Change the approach for ESSL colorisation. Remove the dedicated class and instead define a colourmap to be used with the colorize enhancement. Fix the ratio to be the right way around. Fixes and closes 3020.

gerritholl requested review from djhoese, mraspaud, adybbroe and pnuu as code owners December 18, 2024 15:55

gerritholl force-pushed the new-essl-colorize branch from bab99f9 to 982a31c Compare December 18, 2024 18:23

name should be standard_name

b3e3b31

mraspaud assigned mraspaud and gerritholl and unassigned mraspaud Jan 8, 2025

change standard_name to name in enhancement

d86ee60

Change standard_name back to name in the enhancement, or satpy won't find the correct enhancement and won't use it.

Merge branch 'main' into new-essl-colorize

06abb9a

gerritholl marked this pull request as draft January 17, 2025 14:00

gerritholl added 2 commits January 17, 2025 15:27

Remove unused outdir argument

449a084

Add imagery tests for colorized low level moisture

cc850ab

gerritholl commented Jan 17, 2025

View reviewed changes

gerritholl marked this pull request as ready for review January 17, 2025 15:23

gerritholl commented Jan 17, 2025

View reviewed changes

gerritholl marked this pull request as draft January 17, 2025 16:06

gerritholl commented Jan 17, 2025

View reviewed changes

gerritholl marked this pull request as ready for review January 17, 2025 16:28

mraspaud added enhancement code enhancements, features, improvements component:compositors labels Jan 20, 2025

mraspaud approved these changes Jan 20, 2025

View reviewed changes

mraspaud merged commit 46d54f4 into pytroll:main Jan 20, 2025
17 of 18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change ESSL colorisation approach #3021

Change ESSL colorisation approach #3021

gerritholl commented Dec 18, 2024 •

edited

Loading

codecov bot commented Dec 18, 2024 •

edited

Loading

coveralls commented Dec 18, 2024 •

edited

Loading

mraspaud commented Jan 8, 2025

gerritholl commented Jan 8, 2025

gerritholl left a comment

gerritholl left a comment

gerritholl left a comment

gerritholl left a comment

gerritholl left a comment

gerritholl left a comment

gerritholl left a comment

gerritholl left a comment

gerritholl left a comment

rymdulf commented Jan 17, 2025

rymdulf commented Jan 17, 2025

gerritholl commented Jan 17, 2025

mraspaud commented Jan 20, 2025

mraspaud left a comment

gerritholl commented Jan 20, 2025 •

edited

Loading

Change ESSL colorisation approach #3021

Change ESSL colorisation approach #3021

Conversation

gerritholl commented Dec 18, 2024 • edited Loading

codecov bot commented Dec 18, 2024 • edited Loading

Codecov Report

coveralls commented Dec 18, 2024 • edited Loading

Pull Request Test Coverage Report for Build 12831451262

Details

💛 - Coveralls

mraspaud commented Jan 8, 2025

gerritholl commented Jan 8, 2025

gerritholl left a comment

Choose a reason for hiding this comment

gerritholl left a comment

Choose a reason for hiding this comment

gerritholl left a comment

Choose a reason for hiding this comment

gerritholl left a comment

Choose a reason for hiding this comment

gerritholl left a comment

Choose a reason for hiding this comment

gerritholl left a comment

Choose a reason for hiding this comment

gerritholl left a comment

Choose a reason for hiding this comment

gerritholl left a comment

Choose a reason for hiding this comment

gerritholl left a comment

Choose a reason for hiding this comment

rymdulf commented Jan 17, 2025

rymdulf commented Jan 17, 2025

gerritholl commented Jan 17, 2025

mraspaud commented Jan 20, 2025

mraspaud left a comment

Choose a reason for hiding this comment

gerritholl commented Jan 20, 2025 • edited Loading

gerritholl commented Dec 18, 2024 •

edited

Loading

codecov bot commented Dec 18, 2024 •

edited

Loading

coveralls commented Dec 18, 2024 •

edited

Loading

gerritholl commented Jan 20, 2025 •

edited

Loading