Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] support input/output to fsspec path #2217

Open
leoleoasd opened this issue Dec 31, 2024 · 3 comments
Open

[feature request] support input/output to fsspec path #2217

leoleoasd opened this issue Dec 31, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request triaged This issue has been assigned an owner and appropriate label

Comments

@leoleoasd
Copy link

Support loading model from s3 and save checkpoint to fsspec path.

@ebsmothers
Copy link
Contributor

Hi @leoleoasd thanks for creating the issue. @joecummings is working on updating some of our checkpointing abstractions, so he may have some thoughts on this.

@leoleoasd
Copy link
Author

I researched a little, and I found that safetensor's safeopen uses rust's File::open and MMAP:

https://github.com/huggingface/safetensors/blob/e61e87240d0eabc9749a67ccebe38dca620d48b4/bindings/python/src/lib.rs#L396-L399

So this may not be possible with safetensor?

@joecummings
Copy link
Contributor

I'll have to dig a little deeper on safetensor specifically, but I think the PyTorch Checkpointing team has worked on enabling S3 read/write through use of DCP StorageReaders and StorageWriters: https://pytorch.org/docs/main/distributed.checkpoint.html#torch.distributed.checkpoint.StorageReader

@saumishr / @ankitageorge Is there a good resource for how to create your own adapter and what might be needed for S3?

@ebsmothers ebsmothers added the enhancement New feature or request label Jan 13, 2025
@joecummings joecummings added the triaged This issue has been assigned an owner and appropriate label label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged This issue has been assigned an owner and appropriate label
Projects
None yet
Development

No branches or pull requests

3 participants