Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect return types for peewee #12250

Open
dhorkel opened this issue Jul 1, 2024 · 0 comments
Open

Incorrect return types for peewee #12250

dhorkel opened this issue Jul 1, 2024 · 0 comments

Comments

@dhorkel
Copy link
Contributor

dhorkel commented Jul 1, 2024

The types for in main/stubs/peewee/peewee.pyi are incorrect for _HashableSource and ColumnBase, specifically for the functions __eq__ and __ne__ the return types are set as bool when they should be peewee's Expression class for ColumnBase and for Expression | bool for _HashableSource (or left as Incomplete) as seen here in peewee's repo: https://github.com/coleifer/peewee/blob/2b2e876edf686f3f4ddf5f36df9b978f42504082/peewee.py#L1244

It appears these types were incorrectly added in this commit: 11b842c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant