Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused import in sourcecode #2264

Closed
vignesh7056 opened this issue Mar 26, 2023 · 6 comments
Closed

unused import in sourcecode #2264

vignesh7056 opened this issue Mar 26, 2023 · 6 comments

Comments

@vignesh7056
Copy link

downloads/tests/test_views.py

from rest_framework.authtoken.models import Token

this is an unused import can be removed
@Anuraag-CH
Copy link
Contributor

I remove it and pushed the code and opened a pull request.Could you guide me as to run any tests.

@vignesh7056
Copy link
Author

ok give me the pr link

@vignesh7056
Copy link
Author

its a good practise to give a description for pull request. in this case " refactored source code by removing un used import belongs to "x" module to reduce the technical debt and increase readability of sourcce code."

@sahanasurapureddy
Copy link

Can I work on this issue, if its not resolved it yet?

@hugovk
Copy link
Member

hugovk commented Nov 19, 2023

There's already a PR at #2272

@hugovk
Copy link
Member

hugovk commented Sep 14, 2024

Fixed by #2272.

@hugovk hugovk closed this as completed Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hugovk @vignesh7056 @Anuraag-CH @sahanasurapureddy