Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -Wconversion from CFLAGS_NODIST in --enable-safety #124191

Closed
nohlson opened this issue Sep 17, 2024 · 0 comments
Closed

Remove -Wconversion from CFLAGS_NODIST in --enable-safety #124191

nohlson opened this issue Sep 17, 2024 · 0 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@nohlson
Copy link
Contributor

nohlson commented Sep 17, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

-Wconversion in CFLAGS_NODIST in CI jobs Ubuntu build/test and macOS build/test emits warnings on PRs that have changes unrelated to those warnings. There is an issue in the actions toolkit expressing the same frustration: actions/toolkit#457

We also need to discuss how we will address remediating -Wconversion related warnings if we decide to enable it again.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nohlson