Skip to content

Commit c5f7ef7

Browse files
committed
Remove redundant pickle tests
Remove also DictKey (use Object instead).
1 parent 90842c1 commit c5f7ef7

File tree

2 files changed

+1
-16
lines changed

2 files changed

+1
-16
lines changed

Lib/test/picklecommon.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,9 +243,6 @@ class MyUnicode(str):
243243
class MyUnicode(unicode):
244244
sample = unicode(r"hello \u1234", "raw-unicode-escape")
245245

246-
class DictKey:
247-
pass
248-
249246
class MyTuple(tuple):
250247
sample = (1, 2, 3)
251248

Lib/test/pickletester.py

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2913,7 +2913,7 @@ def test_recursive_frozenset_subclass_and_inst(self):
29132913

29142914
def _test_recursive_collection_in_key(self, factory, minprotocol=0):
29152915
protocols = range(minprotocol, pickle.HIGHEST_PROTOCOL + 1)
2916-
key = DictKey()
2916+
key = Object()
29172917
o = factory({key: 1})
29182918
key.attr = o
29192919
for proto in protocols:
@@ -2924,12 +2924,6 @@ def _test_recursive_collection_in_key(self, factory, minprotocol=0):
29242924
self.assertEqual(len(keys), 1)
29252925
self.assertIs(keys[0].attr, x)
29262926

2927-
def test_recursive_dict_in_key(self):
2928-
self._test_recursive_collection_in_key(dict)
2929-
2930-
def test_recursive_dict_subclass_in_key(self):
2931-
self._test_recursive_collection_in_key(MyDict)
2932-
29332927
def test_recursive_frozendict_in_key(self):
29342928
self._test_recursive_collection_in_key(frozendict, minprotocol=2)
29352929

@@ -2947,12 +2941,6 @@ def _test_recursive_collection_in_value(self, factory, minprotocol=0):
29472941
self.assertEqual(len(x['key']), 1)
29482942
self.assertIs(x['key'][0], x)
29492943

2950-
def test_recursive_dict_in_value(self):
2951-
self._test_recursive_collection_in_value(dict)
2952-
2953-
def test_recursive_dict_subclass_in_value(self):
2954-
self._test_recursive_collection_in_value(MyDict)
2955-
29562944
def test_recursive_frozendict_in_value(self):
29572945
self._test_recursive_collection_in_value(frozendict, minprotocol=2)
29582946

0 commit comments

Comments
 (0)