Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give a better diagnostic if user does trio.to_thread.run_sync(async_fn) #1573

Closed
njsmith opened this issue Jun 4, 2020 · 0 comments · Fixed by #1575
Closed

Give a better diagnostic if user does trio.to_thread.run_sync(async_fn) #1573

njsmith opened this issue Jun 4, 2020 · 0 comments · Fixed by #1575
Assignees
@guilledk
Labels
good first issue

Comments

@njsmith
Copy link
Member

njsmith commented Jun 4, 2020

#1513 fixed the trio.from_thread functions to give nice diagnostics here, but skipped trio.to_thread.

Here's a real user who got confused by this: https://gitter.im/python-trio/general?at=5ed860e2b101510b203789ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guilledk guilledk

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added helpful error message if an async function is passed to trio.to_thread_run_sync guilledk/trio
2 participants
@njsmith @guilledk