-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking change: invert lock --no-update
to lock --update
(or similar)
#3248
Comments
+1 for this feature. Our project is pretty big where many folks, with various skills, contribute and when dependencies move in unexpected ways, it creates lots of waves. It's better to be explicit in such situations and do exactly what the user is requesting. |
@seansfkelley Hi! Does it mean that by using "update command or some kind of --update flag to lock" I'll be able to change current versions of packages in my .lock file? |
If this is implemented, please also make |
@nyuszika7h , Current SQLAlchemy's version is
This doesn't update the SQLAlchemy version and installs all the packages as well. However, in step 3, if you manually add If the above understanding is correct, we will never get into this issue if we use |
Actually, what would be the difference between:
No one of the two will change the content of To me, the two commands are doing the same operation, but maybe I'm just not able to spot the difference. If this is actually true, it would be confusing to have two different commands performing the exact same operation, so I'd rather propose to make |
@alecandido , Yes, I had this doubt as well. I think poetry needs to just provide one way of doing things unless absolutely avoidable. |
Not my words ;)
|
What is the status of this? It's still causing confusion a year later :D |
I think the status is that just doing it would be a breaking change in the user interface and we'll probably don't want to do a major version bump just for this. (This is just my personal opinion.) Some further thoughts: We might need a better name for the new option than I assume we could speed up the progress, if we find a solution without an immediate breaking change (deprecation first) although that would mean more effort - at least if someone is motivated enough to work on such a solution. The only option for a soft change that I can think of is:
After some time with this warning we could switch the behavior of Not sure if that's a good approach. 🤷 |
@radoering may you provide a couple of use cases to understand the difference? This would be a valuable piece of information also in the docs. Moreover, the |
With Personally, I don't use
Or |
Ok, I see. But then there is arguably a strict sorting between E.g. keeping
About this I can only agree :) |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Feature Request
Now that #1614 is fixed and released (yay!), I'd like to propose that for v2, there is a breaking change to make Poetry more opinionated and preserve the versions in the lockfile by default, only updating when explicitly asked to (such as with the
update
command or some kind of--update
flag tolock
). Doing so follows the patterns in analogous tools like Yarn and Cargo and adheres to the principle of least surprise.See also the philosophically-related #2370.
The text was updated successfully, but these errors were encountered: