Is it intended that using poetry shell in fish does not automatically source the virtual environment?

[NiklasKappel]

When I run poetry shell in a fish shell

1. A new subshell is spawned (confirmed by the fact that I have to type exit one more time to close my terminal).
2. My prompt is not modified, but the command line reads source /var/home/niklas/.cache/pypoetry/virtualenvs/ffgp-lwZu11SE-py3.11/bin/activate.fish.
3. I have to press return manually to execute the above line, i.e. to activate the virtual environment. Only then is my shell prompt modified with (ffgp-py3.11).

When I run poetry shell in a bash shell however, the virtual environment is immediately activated and the shell prompt is immediately modified without me having to press return.

Is this normal or intended behavior? I find it mildly inconvenient and am not sure if it warrants opening an issue.

[NiklasKappel]

This seems to be a problem with the sendline method provided by pexpect. Minimal example to reproduce:

import pexpect

child = pexpect.spawn("fish")  # replace with "bash" to see different behavior
child.sendline("echo hello")
child.interact()
child.close()

I will open in issue there.

[NiklasKappel]

pull request for poetry (already merged) is here: #7884 pexcept issue is here: pexpect/pexpect#755 (comment)

…

-----Original Message----- From: Winston H. ***@***.***> Reply-To: python-poetry/poetry ***@***.***> To: python-poetry/poetry ***@***.***> Cc: Niklas Kappel ***@***.***>, State change ***@***.***> Subject: Re: [python-poetry/poetry] Is it intended that using `poetry shell` in fish does not automatically source the virtual environment? (Discussion #7870) Date: 21.05.2023 13:34:25 Have you created an issue? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: ***@***.***>