Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSE boundary conditions don't work with fv4 #301

Open
zingale opened this issue Nov 22, 2024 · 4 comments
Open

HSE boundary conditions don't work with fv4 #301

zingale opened this issue Nov 22, 2024 · 4 comments

Comments

@zingale
Copy link
Collaborator

zingale commented Nov 22, 2024

Not sure why, but they seem to cause the Rayleigh-Taylor to life up as time evolves.

@zingale
Copy link
Collaborator Author

zingale commented Nov 22, 2024

note that it works just fine with compressible_rk using RK4 integration, so the issue seems to be the spatial reconstruction, not the temporal evolution. I suspect that the problem is that the 4th order stencils don't work because we are passing in cell-averages and then we need to do HSE integration on the cell averages, but we are treating them like cell-centers.

@zingale
Copy link
Collaborator Author

zingale commented Nov 22, 2024

it would be better to just add the one-sided stencils to do a better job with reflecting BCs with 4th order, see #244

@zingale
Copy link
Collaborator Author

zingale commented Nov 22, 2024

rt

@zingale
Copy link
Collaborator Author

zingale commented Nov 22, 2024

that's an example ^
left is HSE BCs and right is reflect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant