Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github links points to pymc-devs #96

Open
aloctavodia opened this issue Nov 22, 2023 · 3 comments
Open

github links points to pymc-devs #96

aloctavodia opened this issue Nov 22, 2023 · 3 comments

Comments

@aloctavodia
Copy link
Member

The GitHub icon in our docs links to https://github.com/pymc-devs. Irrespective of whether the docs are for PyMC, PyTensor, PyMC-BART, etc. Is this the intended behavior? I find it annoying and potentially confusing.

@twiecki
Copy link
Member

twiecki commented Nov 22, 2023

That sounds wrong.

@OriolAbril
Copy link
Member

For the main website it is on purpose (pymc, examples and pymc.io), when we restructured the website one of the main goals was to make it look like a single website instead of three different ones. Note that the icon on the navbar is always the same, but the "Edit this page" on the right sidebar is repo specific and points to the right place. For the other ones it could be overriden, but I think it is a sensible default for the pymc-sphinx-theme.

It can be changed from conf.py as shown in https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/header-links.html#icon-links. These values we have by default are the ones in https://github.com/pymc-devs/pymc-sphinx-theme/blob/main/src/pymc_sphinx_theme/components/pymc_icon_links.html

@aloctavodia
Copy link
Member Author

Thanks for the pointer @OriolAbril. Agree is a good default, nevertheless, I changed it in PyMC-BART pymc-devs/pymc-bart#131.

I'm not sure what we want to do with the other repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants