-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotated module level constant not checked for invalid-name
#9770
Comments
I may have gotten that all wrong. |
You did identify a real issue -- annotated statements at the module level are completely escaping any sort of checking for invalid-name -- that can't be right! |
We can discuss what to do in finer-grained detail for these cases in #3585, but for now, suggest to just make |
I agree it's a bug but it's going to create a lot of new messages / spam for a patch (or even a minor) version. I think we should wait for #3585 (comment) to be implemented before merging it (it's as simple as a regex change, right ?). |
Not a regex but something more like a refactor to let the invalid name check do "as-if" checks so a name can be checked twice against two regexes. But yeah, happy to hold this until somebody works on the other one. |
Hm, if the other change is waiting for 4.0 are we willing to let this wait that long also? |
I'm fine with waiting. Bit annoying for users to introduce behaviour that gets replaced a couple of versions later again. |
Originally reported by @mbyrnepr2 in #7232 (comment).
Bug description
Configuration
No response
Command used
Pylint output
Expected behavior
invalid-name
Pylint version
OS / Environment
No response
Additional dependencies
No response
The text was updated successfully, but these errors were encountered: