Incorrect scenario of unidiomatic-typecheck #10161 #10170
+24
β18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #10170 +/- ##
==========================================
- Coverage 95.83% 95.83% -0.01%
==========================================
Files 174 174
Lines 18995 18993 -2
==========================================
- Hits 18204 18202 -2
Misses 791 791
|
DanielNoord
reviewed
Jan 9, 2025
| type(a) is not type({}) | ||
| type(a) is type("") | ||
| type(a) is not type("") | ||
| type(a) == type([]) |
There was a problem hiding this comment.
Doesn't the issue say that we don't want to suggest this but only exclude the is and is not comparisons?
There was a problem hiding this comment.
I think @zenlyj wanted to treat == similarly to is.
Pierre-Sassoulas
added
False Positive π¦
| type(a) is not type({}) | ||
| type(a) is type("") | ||
| type(a) is not type("") | ||
| type(a) == type([]) |
There was a problem hiding this comment.
I think @zenlyj wanted to treat == similarly to is.
| right_arg = utils.safe_infer(right.args[0]) | ||
| if not isinstance(right_arg, LITERAL_NODE_TYPES): | ||
| # not e.g. type(x) == type([]) | ||
| return | ||
| return |
There was a problem hiding this comment.
I'm not sure I would change this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #10161