fix: upgrade to pydicom 3 #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammaxwellxyz
force-pushed
the
fix/pydicom-version
branch
2 times, most recently
from
2ab9825 to
349f364
Compare
|
Tiny conflict and then ready to test! |
sammaxwellxyz
force-pushed
the
fix/pydicom-version
branch
from
349f364 to
672099d
Compare
|
Was there possibly a change with private fields? ######################END########################
.............................WARNING Empty values list encountered. No fields will be identified.
WARNING Empty values list encountered. No fields will be identified.
.................................
======================================================================
FAIL: test_fieldset_remove_private (test_replace_identifiers.TestDicom.test_fieldset_remove_private)
%fields field_set2_private
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/deid/deid/deid/tests/test_replace_identifiers.py", line 518, in test_fieldset_remove_private
self.assertTrue("(0009, 0010)" in parser.lookup["field_set2_private"])
AssertionError: False is not true |
|
another idea is to have a set of helper scripts - not integrated into the main client, but optional to install (and support this extra functionality). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues: #266 #266
Please include a summary of the change(s) and if relevant, any related issues above.
update read_file to dcmread as per suggestion from pydicom 3 release notes https://github.com/pydicom/pydicom/releases/tag/v3.0.0
I couldn't tell if the other changes would cause external breaking changes.
I've run no testing
Checklist
Open questions
Questions that require more discussion or to be addressed in future development:
The approach as here https://github.com/pydicom/deid/pull/267/files may be worthwhile as well to avoid a similar case in the future