Always use np.intp for indices.
#634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
=======================================
Coverage 90.22% 90.23%
=======================================
Files 20 20
Lines 3674 3676 +2
=======================================
+ Hits 3315 3317 +2
Misses 359 359 |
hameerabbasi
force-pushed
the
use-intp-for-idxs
branch
from
f2e43eb
to
3356781
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sparse/_coo/common.py
Outdated
| @@ -1346,9 +1347,10 @@ | |||
|
|
|||
|
|
|||
| def _validate_coo_input(x: Any): | |||
| from .._common import _is_scipy_sparse_obj | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
hameerabbasi
force-pushed
the
use-intp-for-idxs
branch
from
3356781
to
e6f192f
Compare
mtsokol
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #490
Fixes #628