Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colour variables #2058

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Conversation

trallard
Copy link
Collaborator

@trallard trallard commented Nov 28, 2024

While working on the design system documentation, we noticed some fixes needed:

  • Fix heading colour definition: Use same colour as body
  • Add note about zindex: Closes Missing variable: zindex-tooltip #1953
  • Replace the undefined variable with PST variable: we were using --pst-color-panel-background for the background of the card (introduced in Add panels support #641, but it seems this was removed later and it was not properly replaced). Since cards are meant to give some sense of elevation, I replaced this with --pst-color-on-background, which mostly applies to the dark theme (see screenshots below)

Current colour:
image

In this PR:
image

light theme - it's the same before and after as we rely on shadows for elevation
image

cc @smeragoel

@trallard trallard added kind: bug Something isn't working tag: CSS CSS and SCSS related issues labels Nov 28, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@trallard trallard merged commit 25e01e2 into pydata:main Nov 28, 2024
25 checks passed
@trallard trallard deleted the trallard/patch-colour-vars branch November 28, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working tag: CSS CSS and SCSS related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing variable: zindex-tooltip
2 participants