Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add functional submodule #75

Merged
merged 8 commits into from
May 18, 2023
Merged

[ENH] Add functional submodule #75

merged 8 commits into from
May 18, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Apr 27, 2023

Related to: #3

Changes proposed in this pull request:

  • Adds an API sketch for converting an existing graph to a linear functional Gaussian model

This starts some work in the direction of using networkx as the base-layer to enable another big umbrella in causal inference: functional causal graphical models.

In the future, we will want to be able to add arbitrary complexity to the functions and meaning of the edges (kind of like an SCM) that is constrained to the structure of the graph. We should also be able to "inspect" properties if possible, such as weak-faithfulness in the linear case.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Merging #75 (84ce35f) into main (8658c5b) will increase coverage by 0.17%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   84.42%   84.59%   +0.17%     
==========================================
  Files          34       35       +1     
  Lines        2555     2590      +35     
  Branches      687      698      +11     
==========================================
+ Hits         2157     2191      +34     
+ Misses        251      247       -4     
- Partials      147      152       +5     
Impacted Files Coverage Δ
pywhy_graphs/functional/linear.py 85.71% <85.71%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
Signed-off-by: Adam Li <[email protected]>
@adam2392 adam2392 requested a review from bloebp April 29, 2023 01:48
@adam2392
Copy link
Collaborator Author

I will go ahead and merge unless there are objections?

@adam2392 adam2392 merged commit 3de911e into py-why:main May 18, 2023
@adam2392 adam2392 deleted the lin branch May 18, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants