Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEA A function to determine if an edge is "visible" #115

Open
adam2392 opened this issue Jul 15, 2024 · 3 comments · May be fixed by #119
Open

FEA A function to determine if an edge is "visible" #115

adam2392 opened this issue Jul 15, 2024 · 3 comments · May be fixed by #119

Comments

@adam2392
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
In causal graphs (DAG, ADMG, CPDAG, PAG, MAG), there is the notion of an edge being visible. For the DAG/ADMG/CPDAG, edges are by definition always visible.

Describe the solution you'd like
Implement function visible_edge(graph, source, target) to determine if the edge between source and target is visible or not.

One can follow the papers https://auai.org/uai2015/proceedings/papers/155.pdf and https://www.jmlr.org/papers/volume18/16-319/16-319.pdf, and figures to use as unit-test cases.

Additional context
py-why/dowhy#402 (comment)

@adam2392
Copy link
Collaborator Author

cc: @aryan26roy

@aryan26roy
Copy link
Collaborator

@adam2392 does this need to be implemented before #112 ? I kind of forgot the order in which we need to call these functions.

@adam2392
Copy link
Collaborator Author

No I think visibility is a graphical property of an edge.

Proper possibly directed paths is just a generator function for finding paths with specific features. So I think the easiest route is to first implement all_proper_pd_paths generator function, and then implement visible_edge discussed in this GH issue, and then finally implement the generator function for m_separating_sets discussed in #116

@aryan26roy aryan26roy linked a pull request Aug 26, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants