ruff format / lint

Author: DennyDai

src/patcherex2/components/assemblers/assembler.py

@@ -7,7 +7,9 @@ class Assembler:
     def __init__(self, p):
         self.p = p
 
-    def resolve_symbols(self, code, symbols={}):
+    def resolve_symbols(self, code, symbols=None):
+        if symbols is None:
+            symbols = {}
         _symbols = {}
         _symbols.update(self.p.symbols)
         _symbols.update(self.p.binary_analyzer.get_all_symbols())
@@ -23,7 +25,9 @@ def _assemble(self, code, base=0, **kwargs):
     def _pre_assemble_hook(self, code, base=0):
         return code
 
-    def assemble(self, code, base=0, symbols={}, **kwargs):
+    def assemble(self, code, base=0, symbols=None, **kwargs):
+        if symbols is None:
+            symbols = {}
         logger.debug(f"Assembling `{code}` at {hex(base)}")
         code = self.resolve_symbols(code, symbols=symbols)
         code = self._pre_assemble_hook(code, base=base)

src/patcherex2/components/binary_analyzers/angr.py

@@ -90,7 +90,7 @@ def get_unused_funcs(self):
         for func in self.p.kb.functions.values():
             if func.size == 0:
                 continue
-            for dst, xrefs in self.p.kb.xrefs.xrefs_by_dst.items():
+            for dst, _ in self.p.kb.xrefs.xrefs_by_dst.items():
                 if dst == func.addr:
                     break
             else:

src/patcherex2/components/binary_analyzers/binary_analyzer.py

@@ -1,2 +1,2 @@
-class BinaryAnalyzer(object):
+class BinaryAnalyzer:
     pass

src/patcherex2/components/compilers/clang.py

@@ -6,8 +6,10 @@
 
 
 class Clang(Compiler):
-    def __init__(self, p, clang_version=15, compiler_flags=[]):
+    def __init__(self, p, clang_version=15, compiler_flags=None):
         super().__init__(p)
+        if compiler_flags is None:
+            compiler_flags = []
         self._compiler = f"clang-{clang_version}"
         self._linker = f"ld.lld-{clang_version}"
         self._compiler_flags = compiler_flags

src/patcherex2/components/compilers/clang_arm.py

@@ -6,8 +6,10 @@
 
 
 class ClangArm(Compiler):
-    def __init__(self, p, clang_version=15, compiler_flags=[]):
+    def __init__(self, p, clang_version=15, compiler_flags=None):
         super().__init__(p)
+        if compiler_flags is None:
+            compiler_flags = []
         self._compiler = f"clang-{clang_version}"
         self._linker = f"ld.lld-{clang_version}"
         self._compiler_flags = compiler_flags
@@ -16,11 +18,15 @@ def compile(
         self,
         code,
         base=0,
-        symbols={},
-        extra_compiler_flags=[],
+        symbols=None,
+        extra_compiler_flags=None,
         is_thumb=False,
         **kwargs,
     ):
+        if symbols is None:
+            symbols = {}
+        if extra_compiler_flags is None:
+            extra_compiler_flags = []
         if is_thumb:
             extra_compiler_flags += ["-mthumb"]
         else:

src/patcherex2/components/compilers/compiler.py

@@ -12,7 +12,11 @@ class Compiler:
     def __init__(self, p):
         self.p = p
 
-    def compile(self, code, base=0, symbols={}, extra_compiler_flags=[], **kwargs):
+    def compile(self, code, base=0, symbols=None, extra_compiler_flags=None, **kwargs):
+        if symbols is None:
+            symbols = {}
+        if extra_compiler_flags is None:
+            extra_compiler_flags = []
         with tempfile.TemporaryDirectory() as td:
             # source file
             with open(os.path.join(td, "code.c"), "w") as f:

src/patcherex2/patcherex.py

@@ -7,7 +7,9 @@
 
 
 class Patcherex:
-    def __init__(self, binary_path, target_cls=None, target_opts={}):
+    def __init__(self, binary_path, target_cls=None, target_opts=None):
+        if target_opts is None:
+            target_opts = {}
         self.binary_path = binary_path
         if target_cls is None:
             self.target = Target.detect_target(self, binary_path)

src/patcherex2/targets/__init__.py

@@ -2,14 +2,14 @@
 from .elf_arm_linux import ElfArmLinux
 from .elf_arm_mimxrt1052 import ElfArmMimxrt1052
 from .elf_leon3_bare import ElfLeon3Bare
-from .ihex_ppc_bare import IHex_PPC_Bare
+from .ihex_ppc_bare import IHexPPCBare
 from .target import Target
 
 __all__ = [
     "ElfAArch64Linux",
     "ElfArmLinux",
     "ElfArmMimxrt1052",
     "ElfLeon3Bare",
-    "IHex_PPC_Bare",
+    "IHexPPCBare",
     "Target",
 ]

src/patcherex2/targets/ihex_ppc_bare.py

@@ -14,7 +14,7 @@
 logger = logging.getLogger(__name__)
 
 
-class IHex_PPC_Bare(Target):
+class IHexPPCBare(Target):
     NOP_BYTES = b"\x01\x00\x00\x00"
     NOP_SIZE = 4
     JMP_ASM = "b {dst}"

tests/test_aarch64.py

@@ -103,9 +103,7 @@ def test_insert_data_patch(self, tlen=5):
             ldr x1, ={added_data}
             mov x2, %s
             svc 0
-        """ % hex(
-            tlen
-        )
+        """ % hex(tlen)
         p2 = InsertInstructionPatch(0x400580, instrs)
         self.run_one(
             "printf_nopie",

tests/test_arm.py

@@ -107,9 +107,7 @@ def test_insert_data_patch(self, tlen=5):
             ldr r1, ={added_data}
             mov r2, %s
             svc 0
-        """ % hex(
-            tlen
-        )
+        """ % hex(tlen)
         p2 = InsertInstructionPatch(0x103EC, instrs)
         self.run_one(
             "printf_nopie",