-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draggabilly not optional again #212
Comments
@digitalkaoz we had this problem fixed in a PR right? |
@puranjayjain and @digitalkaoz |
@rfontanella we could actually make a guard condition to make it work. Great suggestion btw. |
@puranjayjain As of the latest code the bug exists. moreover the code refers Draggabilly as 'draggabilly' but in the file draggabilly.pkgd.js, it is exported as Draggabilly. hence its never found in the script even if Draggabilly is included in the page. it results in a '_draggabilly2.default is not a constructor' error. |
@puranjayjain This bug is still present. I could not init any time dial. But according to the tip of @rfontanella by removing |
Investigated this issue using the demo which comes with this gulp build: The time picker is not working. Commenting this line it will bring the demo back to life: https://github.com/puranjayjain/md-date-time-picker/blob/master/src/js/mdDateTimePicker.js#L13 |
The time picker works when I use with draggabilly 2.2.0 |
It's mentioned HERE that the Draggabilly is an optional dependency, but when not including it javascript returns an error _Draggabilly2.default is not a constructor and the window doesn't open.
As far as I'm aware there is no flag to set to disable or enable the usage of Draggabilly
This is a copy of the old #196 issue, bu the problem come back
Test it on JsFiddle
The text was updated successfully, but these errors were encountered: