Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draggabilly not optional again #212

Open
rfontanella opened this issue Jul 5, 2017 · 7 comments
Open

Draggabilly not optional again #212

rfontanella opened this issue Jul 5, 2017 · 7 comments

Comments

@rfontanella
Copy link

It's mentioned HERE that the Draggabilly is an optional dependency, but when not including it javascript returns an error _Draggabilly2.default is not a constructor and the window doesn't open.

As far as I'm aware there is no flag to set to disable or enable the usage of Draggabilly

This is a copy of the old #196 issue, bu the problem come back
Test it on JsFiddle

@puranjayjain
Copy link
Owner

@digitalkaoz we had this problem fixed in a PR right?
I will need to recheck it.
Also removing the optional message from docs until we can figure out how to actually make it optional.

@rfontanella
Copy link
Author

rfontanella commented Jul 5, 2017

@puranjayjain and @digitalkaoz
If it helps, commenting line 505 ( this._dragDial(); ) solve the problem and keep the plugin working.
You probably just need a boolean setting to allow/disallow draggability!

@puranjayjain
Copy link
Owner

@rfontanella we could actually make a guard condition to make it work. Great suggestion btw.

@saha-kpghoshal
Copy link

@puranjayjain As of the latest code the bug exists. moreover the code refers Draggabilly as 'draggabilly' but in the file draggabilly.pkgd.js, it is exported as Draggabilly. hence its never found in the script even if Draggabilly is included in the page. it results in a '_draggabilly2.default is not a constructor' error.

@macx
Copy link

macx commented Jan 22, 2018

@puranjayjain This bug is still present. I could not init any time dial. But according to the tip of @rfontanella by removing this_dragDial() I could it make work. Please take your time and fix it!

@macx
Copy link

macx commented Jan 22, 2018

Investigated this issue using the demo which comes with this gulp build: The time picker is not working. Commenting this line it will bring the demo back to life: https://github.com/puranjayjain/md-date-time-picker/blob/master/src/js/mdDateTimePicker.js#L13

@slevy85
Copy link

slevy85 commented Apr 23, 2018

The time picker works when I use with draggabilly 2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants