Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out fixture handling to a separate gem #449

Open
ekohl opened this issue May 1, 2024 · 1 comment
Open

Factor out fixture handling to a separate gem #449

ekohl opened this issue May 1, 2024 · 1 comment

Comments

@ekohl
Copy link
Contributor

ekohl commented May 1, 2024

Use Case

Currently the fixture code is stored inside this gem, but I have another use case (acceptance testing) where I need it. There I don't need puppetlabs_spec_helper (and would even consider dropping it altogether in Vox Pupuli).

Describe the Solution You Would Like

If the code lived in a separate gem, I could just pull that in.

In addition to that, it could properly spec out the file format and behavior.

Additional Context

I have started https://github.com/ekohl/puppet_fixtures, which has a slightly different implementation to allow for better multi-threading. It uses a simple queue and then each thread processes items in the queue.

The current gem could use more testing and documentation, but I'd like to start the conversation on factoring it out. If we don't agree on it, it can bring a split in the community which I'd prefer to avoid.

@bastelfreak
Copy link
Collaborator

@davidsandilands this is part of the effort of aligning the Vox Pupuli and Perforce tooling we talked about. By making PSH more modular it enables us to use it for more usecases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants