Skip to content

Commit 2c72599

Browse files
author
Kyle Dixler
committed
Handle coverage only being on retried tests.
gotestyourself/gotestsum#274 Updates gotestsum to v1.11.0
1 parent 4af97b4 commit 2c72599

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

.github/workflows/ci-run-test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ jobs:
235235
GITHUB_TOKEN: ${{ secrets.PULUMI_BOT_TOKEN }}
236236
with:
237237
repo: gotestyourself/gotestsum
238-
tag: v1.8.1
238+
tag: v1.11.0
239239
cache: enable
240240
- name: Install goteststats
241241
uses: jaxxstorm/[email protected]

.github/workflows/ci.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,9 @@ jobs:
359359
find test-results -mindepth 1 -name '*.json' -mtime +7 -delete
360360
test-collect-coverage:
361361
needs: [unit-test, integration-test, acceptance-test]
362-
if: ${{ inputs.enable-coverage }}
362+
#if: ${{ inputs.enable-coverage }}
363+
# TODO revert this
364+
if: ${{ always() }}
363365
runs-on: ubuntu-latest
364366
steps:
365367
- name: Retrieve code coverage statuses

.github/workflows/on-pr.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,7 @@ jobs:
105105
&& 'macos-latest windows-latest'
106106
|| ''
107107
}}
108-
# We'll only upload coverage artifacts with the periodic-coverage cron workflow.
109-
enable-coverage: false
108+
enable-coverage: true
110109
secrets: inherit
111110

112111
prepare-release:

scripts/go-test.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def heartbeat():
8989
os.mkdir(str(test_results_dir))
9090

9191
json_file = str(test_results_dir.joinpath(f'{test_run}.json'))
92-
args = ['gotestsum', '--jsonfile', json_file, '--rerun-fails=1', '--packages', pkgs, '--'] + \
92+
args = ['gotestsum', '--jsonfile', json_file, '--rerun-fails=1', '--rerun-fails-run-root-test', '--packages', pkgs, '--'] + \
9393
opts
9494
else:
9595
args = ['go', 'test'] + args

0 commit comments

Comments
 (0)