Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do some cleanup #1663

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Do some cleanup #1663

merged 1 commit into from
Jul 8, 2024

Conversation

cnunciato
Copy link
Contributor

@cnunciato cnunciato commented Jul 5, 2024

Does a bit of refactoring to make our GHA jobs much more maintainable:

  • Pulls common setup code into a composite action to reduce a lot of duplication
  • Consolidates multiple workflows into a single workflow that responds to multiple events
  • Deletes two long-failing workflows that aren't used anymore
  • Simplifies and localizes the commands that run the unit tests
  • Deletes some unneeded files in the project root
  • Cleans up some naming for improved readability in the Actions list

Also fixes a bug: apparently the Python unit tests haven't even been running! 🙀

Before:

Ran 0 tests in 0.000s

Now:

3 passed, 3 warnings in 0.36s

Fixes #1661.

@cnunciato cnunciato force-pushed the cnunciato/cleanup branch 30 times, most recently from 998c587 to 989201a Compare July 6, 2024 02:44
Copy link

pulumi-staging bot commented Jul 6, 2024

🍹 The Destroy for pulumi/k8s-ci-cluster/9b27d4b22c0b15ea406d80f5548c532f954b6c9d-60 was successful.

Resource Changes

    Name                                                        Type                                        Operation
-   gke                                                         pulumi:providers:kubernetes                 delete
-   primary-node-pool                                           gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                        gcp:container/cluster:Cluster               delete
-   multicloud                                                  pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                    random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-9b27d4b22c0b15ea406d80f5548c532f954b6c9d-60  pulumi:pulumi:Stack                         delete

@cnunciato cnunciato requested review from sean1588 and removed request for a team July 6, 2024 13:29
@cnunciato cnunciato force-pushed the cnunciato/cleanup branch 8 times, most recently from ccfcfc7 to ce44f66 Compare July 6, 2024 17:23
Copy link

pulumi-staging bot commented Jul 6, 2024

❌ The Update for pulumi/k8s-ci-cluster/d8de76391a707c99b77c513b67287446528d235b-66 failed.

Resource Changes

    Name        Type                                        Operation
+   multicloud  pulumi-kubernetes:ci:GkeCluster             create
+   password    random:index/randomPassword:RandomPassword  create

@cnunciato cnunciato force-pushed the cnunciato/cleanup branch from ce44f66 to e3e66fb Compare July 6, 2024 17:27
Copy link

pulumi-staging bot commented Jul 6, 2024

❌ The Update for pulumi/k8s-ci-cluster/fd3abf77116ff516e1763c6f649db530179e27ad-67 failed.

Resource Changes

    Name        Type                                        Operation
+   multicloud  pulumi-kubernetes:ci:GkeCluster             create
+   password    random:index/randomPassword:RandomPassword  create

Copy link

pulumi-staging bot commented Jul 6, 2024

❌ The Update for pulumi/k8s-ci-cluster/6d454181562ac3884fc3e20694040a3b56efad22-68 failed.

Resource Changes

    Name        Type                                        Operation
+   multicloud  pulumi-kubernetes:ci:GkeCluster             create
+   password    random:index/randomPassword:RandomPassword  create

Copy link

pulumi-staging bot commented Jul 6, 2024

🍹 The Update for pulumi/k8s-ci-cluster/d74170588f8407f2feecb0636a541abd89354b3e-69 was successful.

Resource Changes

    Name                                                        Type                                        Operation
+   k8s-ci-cluster-d74170588f8407f2feecb0636a541abd89354b3e-69  pulumi:pulumi:Stack                         create
+   multicloud                                                  pulumi-kubernetes:ci:GkeCluster             create
+   password                                                    random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                        gcp:container/cluster:Cluster               create
+   primary-node-pool                                           gcp:container/nodePool:NodePool             create
+   gke                                                         pulumi:providers:kubernetes                 create

Copy link

pulumi-staging bot commented Jul 6, 2024

🍹 The Destroy for pulumi/k8s-ci-cluster/d74170588f8407f2feecb0636a541abd89354b3e-69 was successful.

Resource Changes

    Name                                                        Type                                        Operation
-   multicloud                                                  pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                    random:index/randomPassword:RandomPassword  delete
-   k8s-ci-cluster-d74170588f8407f2feecb0636a541abd89354b3e-69  pulumi:pulumi:Stack                         delete
-   gke                                                         pulumi:providers:kubernetes                 delete
-   primary-node-pool                                           gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                        gcp:container/cluster:Cluster               delete

@cnunciato cnunciato force-pushed the cnunciato/cleanup branch 3 times, most recently from b47ac59 to 080b035 Compare July 7, 2024 00:32
Copy link

pulumi-staging bot commented Jul 7, 2024

🍹 The Update for pulumi/k8s-ci-cluster/47e8f7e0b6fb91829d477fb2e04cebd722711848-72 was successful.

Resource Changes

    Name                                                        Type                                        Operation
+   multicloud                                                  pulumi-kubernetes:ci:GkeCluster             create
+   password                                                    random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                        gcp:container/cluster:Cluster               create
+   primary-node-pool                                           gcp:container/nodePool:NodePool             create
+   gke                                                         pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-47e8f7e0b6fb91829d477fb2e04cebd722711848-72  pulumi:pulumi:Stack                         create

Copy link

pulumi-staging bot commented Jul 7, 2024

🍹 The Destroy for pulumi/k8s-ci-cluster/47e8f7e0b6fb91829d477fb2e04cebd722711848-72 was successful.

Resource Changes

    Name                                                        Type                                        Operation
-   k8s-ci-cluster-47e8f7e0b6fb91829d477fb2e04cebd722711848-72  pulumi:pulumi:Stack                         delete
-   gke                                                         pulumi:providers:kubernetes                 delete
-   primary-node-pool                                           gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                        gcp:container/cluster:Cluster               delete
-   multicloud                                                  pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                    random:index/randomPassword:RandomPassword  delete

- uses: actions/checkout@v4

- name: Set up the environment
uses: ./.github/actions/setup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

Copy link
Member

@sean1588 sean1588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cnunciato cnunciato force-pushed the cnunciato/cleanup branch from 080b035 to f88b565 Compare July 8, 2024 16:46
Copy link

pulumi-staging bot commented Jul 8, 2024

🍹 The Update for pulumi/k8s-ci-cluster/d5365072f7dfa136c0294be1c4b3422ce14a1bc3-73 was successful.

Resource Changes

    Name                                                        Type                                        Operation
+   multicloud                                                  pulumi-kubernetes:ci:GkeCluster             create
+   password                                                    random:index/randomPassword:RandomPassword  create
+   ephemeral-ci-cluster                                        gcp:container/cluster:Cluster               create
+   primary-node-pool                                           gcp:container/nodePool:NodePool             create
+   gke                                                         pulumi:providers:kubernetes                 create
+   k8s-ci-cluster-d5365072f7dfa136c0294be1c4b3422ce14a1bc3-73  pulumi:pulumi:Stack                         create

Copy link

pulumi-staging bot commented Jul 8, 2024

🍹 The Destroy for pulumi/k8s-ci-cluster/d5365072f7dfa136c0294be1c4b3422ce14a1bc3-73 was successful.

Resource Changes

    Name                                                        Type                                        Operation
-   k8s-ci-cluster-d5365072f7dfa136c0294be1c4b3422ce14a1bc3-73  pulumi:pulumi:Stack                         delete
-   gke                                                         pulumi:providers:kubernetes                 delete
-   primary-node-pool                                           gcp:container/nodePool:NodePool             delete
-   ephemeral-ci-cluster                                        gcp:container/cluster:Cluster               delete
-   multicloud                                                  pulumi-kubernetes:ci:GkeCluster             delete
-   password                                                    random:index/randomPassword:RandomPassword  delete

@cnunciato cnunciato merged commit e7ba319 into master Jul 8, 2024
47 checks passed
@cnunciato cnunciato deleted the cnunciato/cleanup branch July 8, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor run-tests-command.yml
2 participants