Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate examples not using the EKS component? #1314

Closed
scottslowe opened this issue Dec 3, 2022 · 5 comments
Closed

Deprecate examples not using the EKS component? #1314

scottslowe opened this issue Dec 3, 2022 · 5 comments
Labels
kind/question Questions about existing features resolution/wont-fix This issue won't be fixed

Comments

@scottslowe
Copy link
Contributor

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Now that AWSx has hit 1.0 and is GA, should we deprecate examples that don't use the EKS component? There are several examples in this repository, including (but not limited to) aws-cs-eks, aws-py-eks, and aws-go-eks, that do not use the AWSx EKS component (note that both aws-ts-eks and aws-yaml-eks use AWSx and the EKS component). Or do we feel there is still value in providing examples of creating EKS clusters without the component?

Affected area/feature

This only affects the examples repository.

@scottslowe scottslowe added kind/question Questions about existing features needs-triage Needs attention from the triage team labels Dec 3, 2022
@scottslowe
Copy link
Contributor Author

Tagging @lukehoban @aaronkao @cnunciato for feedback

@roothorp roothorp removed the needs-triage Needs attention from the triage team label Dec 5, 2022
@roothorp
Copy link

roothorp commented Dec 5, 2022

Perhaps @danielrbradley can offer more insight here, but it's my understanding that if people are creating EKS clusters we want to encourage them to be using the EKS component. However, I can see the value in providing some examples for creating EKS clusters with pulumi-aws (without the component).

@cnunciato
Copy link
Contributor

However, I can see the value in providing some examples for creating EKS clusters with pulumi-aws (without the component).

Me too. For some of these, though (especially those that are presented as canonical examples, as these aws-*-eks ones may be), we might want to get them updated to use AWSx. It looks like there may also be slight differences between what these particular examples are doing, so we might want to adjust them to get them aligned resource-wise (such that they're all deploying the same thing) while we're in there. I don't have strong feeling on this, though, but all else equal, I'd probably default to updating them (and their READMEs and referring docs, if any).

@scottslowe
Copy link
Contributor Author

Consensus seems to be that we should have examples that use both the EKS component and pulumi-aws, so closing this issue as not planned.

@scottslowe scottslowe closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2023
@pulumi-bot pulumi-bot reopened this Nov 17, 2023
@pulumi-bot
Copy link

Cannot close issue:

  • does not have required labels: resolution/

Please fix these problems and try again.

@scottslowe scottslowe added the resolution/wont-fix This issue won't be fixed label Nov 17, 2023
@scottslowe scottslowe closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Questions about existing features resolution/wont-fix This issue won't be fixed
Projects
None yet
Development

No branches or pull requests

4 participants