Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to run stylelint #645

Closed
5 tasks done
AlexWayfer opened this issue Jul 17, 2023 · 15 comments · Fixed by pulsar-edit/package-backend#191
Closed
5 tasks done

Unable to run stylelint #645

AlexWayfer opened this issue Jul 17, 2023 · 15 comments · Fixed by pulsar-edit/package-backend#191
Labels
bug Something isn't working

Comments

@AlexWayfer
Copy link

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

ENOENT, static/index.json not found in /opt/Pulsar/resources/app.asar

image

Package: https://web.pulsar-edit.dev/packages/linter-stylelint

Pulsar version

107.1

Which OS does this happen on?

🐧 Arch based (Manjaro, Garuda, etc.)

OS details

Arch, GNOME

Which CPU architecture are you running this on?

64-bit(x86_64)

What steps are needed to reproduce this?

  1. Install linter-stylelint
  2. Enable it

Additional Information:

I've not tried in safe or debugging modes.

Is it package-related issue or you can deal with it?

Sorry, there are no discussion, so I'm creating an issue.

@AlexWayfer AlexWayfer added the bug Something isn't working label Jul 17, 2023
@confused-Techie
Copy link
Member

So I haven't dug to far into this package's code, but if I had to guess it seems this is an issue with the package itself.

The error is emitted here which seems to stem from a catch handler failing to account for the failure occurring.

Additionally, this seems to match an error being reported on the repo itself that began in Atom.

So I'm willing to bet this is something wrong within the package itself, but would be more than happy to discover otherwise.

@savetheclocktower
Copy link
Contributor

There's a PR in that repo that claims to fix that issue.

In theory, one should be able to run

ppm install jsit/linter-stylelint -b stylelint-14

to install the version of the extension from that PR, but ppm isn't able to find that branch, even though it exists. @confused-Techie, do we know why ppm is doing the wrong thing there?

@confused-Techie
Copy link
Member

@savetheclocktower I'm not to familiar with the behavior of PPM installing from a repo. @mauricioszabo was the one who originally authored the behavior and hopefully could provide some insight.

But let me find the PR claiming a fix

@confused-Techie
Copy link
Member

Alternatively, seems the user providing that fix, has a fork of the package themselves, that's nearly 200 commits ahead of the published package.

Here is the fork I may honestly recommend installation of this to test out, and if it truly works properly, we can add a broken badge status to the published package and recommend installation of this fork.

@AlexWayfer
Copy link
Author

Additionally, this seems to match an error being reported on the repo itself that began in Atom.

Yeah, I completely forgot about this, and my bad I've not checked package's issues, sorry.

Here is the fork I may honestly recommend installation of this to test out, and if it truly works properly

It's a good find, thanks.

we can add a broken badge status to the published package and recommend installation of this fork.

Interesting idea. Probably we also should contact with the author of the fork, maybe they want to publish their version of the package for Pulsar.

@confused-Techie
Copy link
Member

@AlexWayfer Fantastic idea on wanting to reach out to that author first, and already commented on your issue you've created.

So lets wait to hear back, but I have high hopes that either way this fork can resolve these issues for us, so fingers crossed

@AlexWayfer
Copy link
Author

ppm install jsit/linter-stylelint -b stylelint-14
> pulsar -p install jsit/linter-stylelint -b stylelint-14
Cloning https://github.com/jsit/linter-stylelint.git ✓
Can't find the branch, tag, or commit referenced by stylelint-14

Here is the fork I may honestly recommend installation of this to test out, and if it truly works properly, we can add a broken badge status to the published package and recommend installation of this fork.

Unfortunately, it doesn't: alexrudd2/linter-stylelint#162


A little off-topic: how do you use ppm? I have installed Pulsar on Arch Linux from AUR and have no such command, I have to use pulsar -p.

@confused-Techie
Copy link
Member

So @AlexWayfer while we made a best effort to attempt to contact the owner of the fork, seems they are unresponsive, and I'll prioritize adding a broken badge to this package, so we can close this issue. Thanks for attempting to contact the maintainer.

@AlexWayfer
Copy link
Author

I'll prioritize adding a broken badge to this package, so we can close this issue

As you wish, you can close (I don't know if the badge is required before closing).

@confused-Techie
Copy link
Member

I'll prioritize adding a broken badge to this package, so we can close this issue

As you wish, you can close (I don't know if the badge is required before closing).

Thanks for understanding. I'll leave it open until the badge is added, as it's a good reminder for me to do so

@Spiker985
Copy link
Member

@confused-Techie Reminder on broken badge, just in case

@confused-Techie
Copy link
Member

Thank you @Spiker985

@alexrudd2
Copy link

alexrudd2 commented Aug 18, 2023

I'm the author of the "fork," although I use that term loosely. All I ever did was run dependabot, since I don't actually understand the code.

That said, it now runs for me (albeit with old stylelint==13.13.1) on Atom. EDIT: and Pulsar

@confused-Techie
Copy link
Member

I'm the author of the "fork," although I use that term loosely. All I ever did was run dependabot, since I don't actually understand the code.

That said, it now runs for me (albeit with old stylelint==13.13.1) on Atom. EDIT: and Pulsar

Glad to see you chiming in. If you ever wanted I'd be more than happy to help you out with publishing this package to Pulsar, or if you'd rather with write permissions I'd be happy to publish myself, so that the community can enjoy having a stylelint package that functions properly

@alexrudd2
Copy link

Sure, invited you as a collaborator!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
5 participants