Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit and confirm that all applications on the load balancers are forwarding the protocol #5472

Open
1 of 4 tasks
acozine opened this issue Oct 25, 2024 · 3 comments
Open
1 of 4 tasks

Audit and confirm that all applications on the load balancers are forwarding the protocol #5472

acozine opened this issue Oct 25, 2024 · 3 comments
Labels
maintenance post-incident created from a post-incident meeting

Comments

@acozine
Copy link
Contributor

acozine commented Oct 25, 2024

What maintenance needs to be done?

Make sure that all sites on our LBs have the X-Forwarded-Proto setting turned on in nginxplus config.

See #5404 as an example.

Level of urgency

  • High
  • Moderate
  • Low

Acceptance criteria

  • all configs in roles/nginxplus/files/config/http/ have the X-Forwarded-Proto line

Implementation notes, if any
@acozine acozine added maintenance post-incident created from a post-incident meeting labels Oct 25, 2024
@tpendragon tpendragon added the dls-work-cycle Ticket for DLS to work during their work cycle label Nov 12, 2024
@tpendragon
Copy link
Contributor

First Step for DLS

Look at the nginx configs for DLS apps and see if that line is there.

@carolyncole carolyncole self-assigned this Nov 19, 2024
@carolyncole carolyncole mentioned this issue Nov 20, 2024
Merged
@carolyncole
Copy link
Member

I believe this is complete for RDSS apps.

@carolyncole carolyncole removed their assignment Nov 20, 2024
@hackartisan hackartisan self-assigned this Dec 4, 2024
hackartisan added a commit that referenced this issue Dec 4, 2024
@hackartisan
[nginxplus] Add X-Forwarded-Proto headers to all DLS configs
0f34e4c 
advances #5472
@hackartisan hackartisan mentioned this issue Dec 4, 2024
Merged
tpendragon pushed a commit that referenced this issue Dec 4, 2024
@hackartisan
[nginxplus] Add X-Forwarded-Proto headers to all DLS configs (#5587)
39130d2 
advances #5472
@hackartisan
Copy link
Member

Complete for DLS

@hackartisan hackartisan removed their assignment Dec 4, 2024
@hackartisan hackartisan removed the dls-work-cycle Ticket for DLS to work during their work cycle label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance post-incident created from a post-incident meeting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hackartisan @acozine @carolyncole @tpendragon