Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to jade-parser etc. #17

Open
TimothyGu opened this issue Jun 4, 2015 · 5 comments
Open

Switch to jade-parser etc. #17

TimothyGu opened this issue Jun 4, 2015 · 5 comments

Comments

@TimothyGu
Copy link
Member

No description provided.

@jeromew
Copy link
Contributor

jeromew commented Jun 5, 2015

@TimothyGu currently then-jade is bound on jade 1.3.0

My objective is to reach a state-of-the-art jade dependency while avoiding manual upgrades because the monkey-patching is a bit cumbersome.

When the jade 2.x project started, I told to myself that I would

  • wait until 2.x was released,
  • do a last then-jade dependency update on the last 1.x
  • and then adopt the new modular architecture

when you say "switch to jade-parser" etc, do you mean (I haven't checked) that this module split has already been done in the 1.x branch (not waiting for 2.x) ?

If yes, can you tell me what was the last jade version with the old monolithic approach ? I would then updgrade then-jade to this version and start thinking about the effects of the modular design on then-jade.

@TimothyGu
Copy link
Member Author

when you say "switch to jade-parser" etc, do you mean (I haven't checked) that this module split has already been done in the 1.x branch (not waiting for 2.x) ?

No, I'm just raising awareness that at some point we should switch.

Thanks!

@jeromew
Copy link
Contributor

jeromew commented Jun 18, 2015

then-jade is now upgraded to jade 1.11.0 (hopefully the last jade release on the 1.x release path)
I haven't done any research yet regarding the migration to the new architecture that is envisioned for the upcoming jade 2.0 release

@jonathanong
Copy link
Contributor

jonathanong commented Mar 28, 2017

i would like to know: is there an intent to migrate to the pugjs v2 architecture? not sure if i should bother using this while i migrate to pug. thanks!

@jeromew
Copy link
Contributor

jeromew commented Mar 28, 2017

check pugjs/pug#2708 for news on this.

I published https://www.npmjs.com/package/then-pug which is a working implementation based on pug head (I use this and don't use then-jade anymore)

There is still work before the babel AST based code-gen lands into pug master so until then I think the project needs to be considered experimental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants