Fix to address #3263 and #3447 for "in" usage #3448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was still hitting issue pugjs#3263 when using "in" instead of "of" (which caused other odd problems). The regex was looking for * (0+) spaces instead of + (at least one) space. Using + instead prevents the regex from catching "in ofxxxxx".
pug-lexer (5.0.1 → 5.0.2)Bug Fixes
Packages With No ChangesThe following packages have no user facing changes, so won't be released:
|
fpereira1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was still hitting issue #3263 when using "in" instead of "of" (which caused other odd problems). The regex was looking for * (0+) spaces instead of + (at least one) space. Using + instead prevents the regex from catching "in ofxxxxx".
BTW, I have cherry-picked the commit from another PR (#3318), added more context to it by creating and issue (#3447) with a minimal reproducible example, brought this work up to date with
masterand filled in the details for release on the rollingversions botfixes: #3447, fixes #3263