Added limit and offset to HereNow API#121
Merged
marcin-cebo merged 12 commits intomasterfrom Oct 28, 2025
Merged
Conversation
Default and max value for limit is 1000
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
seba-aln
reviewed
Oct 27, 2025
seba-aln
left a comment
seba-aln
left a comment
There was a problem hiding this comment.
I will try to dig deeper into those two new helper files,my gut tells me there's something fishy wit them
.gitignore
Outdated
| # Environment files (for local development) # | ||
| ############################################# | ||
| .env | ||
| .env.local |
There was a problem hiding this comment.
it's more like:
.env.dev
.env.test
.env.prod
and I'm not sure if you need to ignore them apart of .env.dev
Contributor
Author
There was a problem hiding this comment.
I guess those files might store e.g. SECRET_PAM_KEY
We don't want to expose it by adding to repo
| error_reporting(E_ALL); | ||
|
|
||
| // Load environment variables from .env file (for local development) | ||
| // This allows developers to set PUBLISH_KEY, SUBSCRIBE_KEY, etc. locally |
There was a problem hiding this comment.
consider removing comments below. they look redundant and "artificial"
tests/e2e/HereNowE2eTest.php
Outdated
|
|
||
| // Verify paginated results don't overlap with first page | ||
| $secondPageUuids = array_map( | ||
| function($occupant) { return $occupant->getUuid(); }, |
There was a problem hiding this comment.
Suggested change
| function($occupant) { return $occupant->getUuid(); }, | |
| fn ($user) => $user->getUuid(), |
… to .env.dev we need to explicitly specify it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default and max value for limit is 1000