-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure compatiblity with /lib/exporter.rb in MapKnitter #5
Comments
This should use usable as in the tests, after including the gem, and then:
Although I think it'll be |
Also we need to pass in this nice MockExport object: mapknitter-exporter/test/exporter_test.rb Lines 125 to 133 in bf375b6
|
|
Following publiclab/mapknitter#364 (comment) |
And we'll have to refactor from the simplified version here: #6 !! |
After refactoring "root" we should be ok to do this. |
OK, #530 brings mapknitter up to date with the latest of this gem! |
There've been minimal changes to the library itself, but 2 to watch out for are:
object.lat
toobject[:lat]
everywhere, similar for[:nodes_array]
image.url
to stringimage_url
inrun_export
Here's a diff of the file from the original copy in from MapKnitter:
e140646...bf375b6#diff-174ec2997e5f3c6e51179e598ab47217R314
We should be able to get MapKnitter to install this gem and still pass it's test at
/tests/unit/exporter_test.rb
if we respect these changes.The text was updated successfully, but these errors were encountered: