Crashes on startup

[icarito]

Running the command as per Dockerfile:

ruby app.rb ....

just returns. No server is started. This is causing crash loop.

[icarito]

Last working container since January.

[jywarren]

:-(

So, looking at the commit history, that would be 7aa8ce7

Travis has passed on basically everything since then, so hopefully it's a small issue in 60af4ea or 1ed55b4 ?

60af4ea makes significant changes to the Dockerfile. It was part of pull request #58

Actually it seems the changes are reverted in later commits, so the ultimate changes merged were not that significant:

https://github.com/publiclab/mapknitter-exporter-sinatra/pull/58/files

So, we should be perhaps running ruby app.rb in our tests just as a check -- we could add a .travis.yml entry for that:

mapknitter-exporter-sinatra/.travis.yml

Lines 21 to 28 in f873043

	jobs:
	include:
	- name: "Exporter Tests"
	script: bundle exec rspec
	- name: "Rubocop Build"
	script: bundle exec rubocop
	- name: "Docker Build"
	script: docker build . -t lib-mapknitter-exporter:latest

We are requiring app.rb but we aren't running it with ruby app.rb --

mapknitter-exporter-sinatra/spec/landing_spec.rb

Lines 15 to 29 in f873043

	require_relative "../app.rb"
	require "rspec"
	require "rack/test"
	describe "Mapknitter Exporter" do
	include Rack::Test::Methods
	def app
	Sinatra::Application
	end
	it "displays Mapknitter Exporter text" do
	get "/"
	expect(last_response.body).to match("Mapknitter Exporter")
	end

Trying to boot it up in GitPod... got what you did.

https://github.com/publiclab/mapknitter-exporter-sinatra/commits/main/app.rb has had 2 commits since Jan...

[jywarren]

5e50ff9 and 5f3ab82 ...

whoaaaa...

mapknitter-exporter-sinatra/app.rb

Line 1 in f873043

require_relative "lib/export.rb"

I think that's a mistake -- shouldn't app.rb be:

require_relative "app/controllers/export_controller.rb" ? Even when I change it to that, the app doesn't boot.

Hmm, chasing that require, it went to:

mapknitter-exporter-sinatra/lib/export.rb

Line 1 in f873043

require_relative "../app/controllers/export_controller.rb"

@alaxalves something weird is happening here. Isn't ruby app.rb supposed to boot the application? If not, could you note the command to do so?

https://github.com/publiclab/mapknitter-exporter-sinatra/commits/main/lib/export.rb

I'm a little confused at why it's requiring the lib/export.rb file -- why do we have that file, shouldn't it be using the gem at https://github.com/publiclab/mapknitter-exporter ? We had been doing that here:

mapknitter-exporter-sinatra/app.rb

Line 16 in 7aa8ce7

require "mapknitterExporter"

Any help appreciated, thanks @alaxalves !