-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a language section above first-timers only issue #337
Comments
@govindgoel May I work upon this? |
@akanksha-v Yeah you can work on this, it would be better if we go for languages of each repo if you have some other sort of design from which is discussed do share. |
Hi, @akanksha-v You working on this? |
@YogeshSharma01 you can work upon this |
@akanksha-v Ok cool! |
hi, @govindgoel we can fetch the name of the repo, the link, and the language for all the repository in the public lab by using GitHub API. |
@govindgoel, @akanksha-v what do you think about it? |
@YogeshSharma01 yeah it can be done, I was thinking of an approach where language can be specified somewhere else as it may look crowded at this place. |
hi, @govindgoel no I don't think it would be crowded like the repo name with the link of that particular repo will be set at the left corner in the language section and the language is used in that particular repo will be placed at the right corner and we can also use some special icons to represent the language used in the repo. |
Hi, @govindgoel what do you think? Do we need to add anything more? Video-Language-Section.mov |
I give a pull request, please review @govindgoel |
It seems crowded and will lead to more scrolling, it would be great if we
can find a way to show the language with respect to the repo name in the
dropdown.
Warm Regards,
Govind Goel
|
Hi, @govindgoel Language-section.movWhat do you think is this fine? Now we don't need to scroll the Language-section and also it don't look crowedy now. |
Hi, @govindgoel please review the changes I have updated the changes. |
Hi, @govindgoel please review |
Hi, I'm sorry I missed this conversation! I really appreciate it. However, i wonder if we need to put this section at the bottom of the page and link down to it from the new navbar. Because we really want people to be able to see the first-timers-only issues as close to the top as possible! Another possibility is that in the first-timers-only issues explanation text, as shown below the header in this screenshot, we could add the line "You can also sort by language" which then links down to the languages section. How does that sound? |
Hi, @jywarren that sounds awesome ok I'll place this section at the bottom of the page and add the line "You can also sort by language" which then links down to the languages section. |
@jywarren how does it look ...? language.section.at.bottom.mov |
This looks great! One more request though -- can we add the text description "Hover over each project to see what languages it uses"? I might prefer a visible label though because this won't work in mobile, you know? But, tell me what you think! Could we add labels in this style, maybe? I'm just worried about the visibility on mobile, you know? Thank you!! |
Hi @jywarren, Yes you're right it won't work on mobile we can add labels in this style like repo name at the left corner and the language used on the right side. And like this ... we don't even need to use this hover and can show language on mobile too! So, what do you think? |
@jywarren I have another idea to implement this, we can think of displaying it in the dropdown list of repo's itself then there will be no need for a new section. |
@govindgoel like we can do that but I think it would look crowded like all the repo names within a single dropdown? Can you please show some mockup or sketch for a better understanding? That would be a big help. |
Hi @YogeshSharma01 i like your last design, let's give it a try! @govindgoel i appreciate your idea as well; one way we could do this is to consider having this selection show only the top 3-5, and have a button that says "See all" or "Expand to see all" which opens the full box. What do you think? |
Hi, @jywarren and @govindgoel sorry for the late reply actually I was busy with my exams Please review this. Language-section.movand also review the PR #422 |
Please describe the idea:
It would be great if we can add a section that fetches what are the languages used in that repository.It would be great as it will give a idea to newcomers on which project they should contribute ,and
github-api-simple
has api for this purpose also or we can use Github linguist.Something like this
Please show us where to look
https://code.publiclab.org/ ...
What's your PublicLab.org username?
Browser, version, and operating system
Thank you!
Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.
To learn how to write really great issues, which increases the chances they'll be resolved, see:
https://publiclab.org/wiki/developers#Contributing+for+non-coders
The text was updated successfully, but these errors were encountered: