-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the use of document.querySelector to a more local search using 'this' #1368
Comments
Thanks for opening your first issue here! This space is protected by our Code of Conduct - and we're here to help. |
@AliyanH Can I work on this issue? |
Yup, good with me. Thanks! |
Hello,
document.querySelector
returns the first element in the document matching the specified selector. This can cause an issue when the web page has multiple Leaflet maps in the page (as the first map will always be selected even when called from the second map).Similarly,
document.querySelector
does not search inside of a ShadowRoot which can cause an issue when the leaflet map is inside of one, and create an error (which is the case for me).I believe the use of
document.querySelector
can be changed to do a more local search for the map, which can always return the right element. For ex, the following code (which is causing an error for me) can be change from this:Leaflet.DistortableImage/src/edit/actions/EditAction.js
Line 81 in ccf6e69
To this:
this._map._container.querySelector('.leaflet-marker-pane').appendChild(el);
Please let me know what you think, Thanks.
The text was updated successfully, but these errors were encountered: