-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReceiveApproval callback #124
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
How about adding
ReceiveApproval
callback?Logically speaking, receiving an approval to use the NFT has the same meaning as receiving the actual NFT, as far as the contract cares.
This will make the flow much easier for marketplaces that use approval system, instead of a 2 msg system, where you first send approval, and then send the actual msg.
This will reduce complexity by a lot, and reduce number of queries needed, right now on each marketplace listing, you need to query for owner and approvals, this callback will make those queries not needed as you can just pass data with the callback.
We can add the callback to existing approval msg, or create a new message (much like transfer and send).
Same idea can be applied to revoke.
Benefits:
The text was updated successfully, but these errors were encountered: