Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering based on labels stopped working since 1.8.9 #491

Open
verebes1 opened this issue Nov 8, 2023 · 6 comments
Open

Filtering based on labels stopped working since 1.8.9 #491

verebes1 opened this issue Nov 8, 2023 · 6 comments
Assignees

Comments

@verebes1
Copy link

verebes1 commented Nov 8, 2023

I noticed a weird behaviour I had Trailer fully set up and was happily tracking all the relevant PRs excluding certain labels like do not merge or excluding dependabot PRs
However with the recent updates to 1.8.10 and then to 1.8.11
These stopped working. I tried removing the label and adding it again and I can see some repos hiding but not all of them for some reason despite having the do not merge label attached to them.

Another issue that I was having in addition to filtering that I do not get the updates on the PRs like I used to eg:
A PR has been approved still shows as nothing happened on it for days. Seems like Trailer stopped updating. I tried reloading all the data and that did not solve the issue.

Any ideas how to work on this? Would I need to set everything up from scratch again?

Reverting to version 1.8.9 seems to fixed the issues.

@verebes1
Copy link
Author

Update on the above issue. I noticed that this issue is not showing on my other mac (Apple Silicon). So I believe this has somehow got corrupt on my main mac (Intel based). I tried reloading all the data and it helps up until I disable wifi and re-enable it again or up until the restart of the mac.

Is there a way to fully uninstall everything to set it up from scratch again? I tried removing everything from the ~/Library/Preferences
That I could find that related to trailer and then reimporting the settings file that was previously exported but that also brings back the issue.
Is it possible that the settings file has something inside that is causing the issue to reoccur or can it be specific to the intel macs?

@ptsochantaris
Copy link
Owner

Hi and sorry for the very slow reply. If you want to completely zap Trailer, the best way is to remove the app, the prefs file - like you mention - and also the data directory ~/Library/Application\ Support/com.housetrip.Trailer. That said, I find it interesting that the specific instance breaks only if you disable your WiFi - it sounds like perhaps some error handling is breaking when a sync fails. Can you give me a way to try and reproduce the issue?

@ptsochantaris ptsochantaris self-assigned this Jan 19, 2024
@verebes1
Copy link
Author

verebes1 commented Jan 22, 2024

Unfortunately I have another mac which is on Apple Silicon and I cannot reproduce the same issue 🤷
but if I find a way then I will let you know.

@verebes1
Copy link
Author

One thing that is interesting though if I reinstall the app after fully nuking everything and reimport the settings that were working on the mac with AppleSilicon. It fails to show the approval state. The only solution so far that I found is to switch to the v4 API. I think the issue might be somewhere in the settings import phase. I will report back if the Wifi issue happens again. If so I might have to go about and set everything up manually again.

@verebes1
Copy link
Author

verebes1 commented Feb 1, 2024

I have a quick question on resetting. I removed all the settings and reinstalled trailer after a mac reboot. Despite the fact that I was adding a new api token and setting it up from scratch it still remembered my filters from the previous install and also knew where my settings export was.
Is there another file location that Trailer uses to load config on the filesystem?

@ptsochantaris
Copy link
Owner

ptsochantaris commented Feb 3, 2024

Hi @verebes1 - macOS sandboxing means that preferences tend to be spread out all over the filesystem. One app (I'm not affiliated with them, but definitely worth investigating) is AppCleaner. Using it on Trailer will give the following paths:

Screenshot 2024-02-03 at 12 15 35

So ideally you'd want to nuke all of those (even the one that for some reason above isn't automatically ticked)

Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants