Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use function with easier input for generating PRX module files #243

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

sharkwouter
Copy link
Member

This would make using this a bit easier. Right now you have to do this:

add_prx_module(TARGET myprx
    SRC_FILES main.c extra.c
    EXP_FILES main.exp extra.exp
)

This change would allow you to do this instead:

add_prx_module(myprx
    main.c
    extra.c
    main.exp
    extra.exp
)

The function will figure out which of the files specified are exp files and generate c files from them without the user needing to make a distinction.

@sharkwouter sharkwouter marked this pull request as draft October 31, 2024 08:27
@sharkwouter sharkwouter marked this pull request as ready for review October 31, 2024 08:50
Copy link
Member

@fjtrujy fjtrujy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement!

@sharkwouter sharkwouter merged commit 3bdfee4 into master Oct 31, 2024
2 checks passed
@sharkwouter sharkwouter deleted the make-add-prx-module-into-function branch October 31, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants