From e70e9f4eb8268b591c2bfe3b3b12b41671c84281 Mon Sep 17 00:00:00 2001 From: Juan David Nicholls Cardona Date: Mon, 28 Jun 2021 09:58:21 -0500 Subject: [PATCH] Fix issues with navigationBarColor and navigationBarDividerColor Android options --- CHANGELOG.md | 8 +++++++- src/InAppBrowser.android.ts | 4 ++-- src/package-lock.json | 4 ++-- src/package.json | 3 ++- src/tsconfig.json | 12 ++++++------ src/types/android.d.ts | 4 ++++ 6 files changed, 23 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 95e7653..59e7a2a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,11 @@ in case of vulnerabilities. ## [Unreleased] +## [3.1.1] - 2021-06-28 + +### Fixed +- Fix issues with `navigationBarColor` and `navigationBarDividerColor` Android options. + ## [3.1.0] - 2021-06-27 ### Added @@ -97,7 +102,8 @@ in case of vulnerabilities. - Methods to open and close external urls to authenticate the user **(openAuth, closeAuth)** using deep linking. - `isAvailable` method to detect if the device supports the plugin. -[Unreleased]: https://github.com/proyecto26/nativescript-inappbrowser/compare/v3.1.0...HEAD +[Unreleased]: https://github.com/proyecto26/nativescript-inappbrowser/compare/v3.1.1...HEAD +[3.1.1]: https://github.com/proyecto26/nativescript-inappbrowser/compare/v3.1.0...v3.1.1 [3.1.0]: https://github.com/proyecto26/nativescript-inappbrowser/compare/v3.0.2...v3.1.0 [3.0.2]: https://github.com/proyecto26/nativescript-inappbrowser/compare/v3.0.1...v3.0.2 [3.0.1]: https://github.com/proyecto26/nativescript-inappbrowser/compare/v3.0.0...v3.0.1 diff --git a/src/InAppBrowser.android.ts b/src/InAppBrowser.android.ts index bb1d278..8ad927d 100644 --- a/src/InAppBrowser.android.ts +++ b/src/InAppBrowser.android.ts @@ -127,14 +127,14 @@ function setup() { if (colorString) { const color = tryParseColor(colorString, 'Invalid navigation bar color'); if (color) { - builder.setSecondaryToolbarColor(color.android); + builder.setNavigationBarColor(color.android); } } colorString = inAppBrowserOptions[InAppBrowserModule.KEY_NAVIGATION_BAR_DIVIDER_COLOR]; if (colorString) { const color = tryParseColor(colorString, 'Invalid navigation bar divider color'); if (color) { - builder.setSecondaryToolbarColor(color.android); + builder.setNavigationBarDividerColor(color.android); } } diff --git a/src/package-lock.json b/src/package-lock.json index 7efa5d1..ed236de 100644 --- a/src/package-lock.json +++ b/src/package-lock.json @@ -1,12 +1,12 @@ { "name": "nativescript-inappbrowser", - "version": "3.1.0", + "version": "3.1.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "nativescript-inappbrowser", - "version": "3.1.0", + "version": "3.1.1", "license": "MIT", "devDependencies": { "@nativescript/core": "~7.0.0", diff --git a/src/package.json b/src/package.json index d410dca..28b59dc 100644 --- a/src/package.json +++ b/src/package.json @@ -1,6 +1,6 @@ { "name": "nativescript-inappbrowser", - "version": "3.1.0", + "version": "3.1.1", "description": "InAppBrowser for NativeScript", "main": "InAppBrowser", "typings": "index.d.ts", @@ -15,6 +15,7 @@ "url": "https://github.com/proyecto26/nativescript-inappbrowser.git" }, "scripts": { + "setup": "npm i && ts-patch install", "tsc": "npm i && ts-patch install && tsc", "build": "npm run tsc && npm run build.native", "build.native": "node scripts/build-native.js", diff --git a/src/tsconfig.json b/src/tsconfig.json index 52284a9..b884c3a 100644 --- a/src/tsconfig.json +++ b/src/tsconfig.json @@ -21,12 +21,12 @@ "noImplicitUseStrict": false, "noFallthroughCasesInSwitch": true, "baseUrl": ".", - "plugins": [ - { - "transform": "@nativescript/webpack/transformers/ns-transform-native-classes", - "type": "raw" - } - ] + "plugins": [ + { + "transform": "@nativescript/webpack/transformers/ns-transform-native-classes", + "type": "raw" + } + ] }, "exclude": [ "node_modules" diff --git a/src/types/android.d.ts b/src/types/android.d.ts index a2ba7ce..25ee076 100644 --- a/src/types/android.d.ts +++ b/src/types/android.d.ts @@ -19,6 +19,8 @@ declare namespace android { setShowTitle(showTitle: boolean): this; setToolbarColor(color: number): this; setSecondaryToolbarColor(color: number): this; + setNavigationBarColor(color: number): this; + setNavigationBarDividerColor(color: number): this; addDefaultShareMenuItem(): this; enableUrlBarHiding(): this; setStartAnimations(context: android.content.Context, enterResId: number, exitResId: number): this; @@ -51,6 +53,8 @@ declare namespace androidx { setShowTitle(showTitle: boolean): this; setToolbarColor(color: number): this; setSecondaryToolbarColor(color: number): this; + setNavigationBarColor(color: number): this; + setNavigationBarDividerColor(color: number): this; addDefaultShareMenuItem(): this; enableUrlBarHiding(): this; setStartAnimations(context: android.content.Context, enterResId: number, exitResId: number): this;