From 23c8ab983373c8046c487a92fd5232bbc0b16e85 Mon Sep 17 00:00:00 2001 From: Sofia Leon Date: Tue, 15 Oct 2024 17:30:32 -0700 Subject: [PATCH] respond to comments --- tests/feature_resolution_editions.js | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/tests/feature_resolution_editions.js b/tests/feature_resolution_editions.js index 4152a2513..cb2b8af52 100644 --- a/tests/feature_resolution_editions.js +++ b/tests/feature_resolution_editions.js @@ -237,11 +237,11 @@ tape.test("feature resolution inheritance oneofs", function(test) { var rootEditionsOverriden = protobuf.parse(` edition = "2023"; option features.(abc).d_e = deeply_nested_false; - message Message {∂ + message Message { oneof SomeOneOf { option features.json_format = LEGACY_BEST_EFFORT; int32 a = 13; - string b = 14; + string b = 14 [features.json_format = ALLOW]; } }`).root.resolveAll(); @@ -255,21 +255,6 @@ tape.test("feature resolution inheritance oneofs", function(test) { '(abc)': { d_e: 'deeply_nested_false' } }) - test.end(); -}); - -tape.test("feature resolution inheritance oneofs to field", function(test) { - var rootEditionsOverriden = protobuf.parse(` - edition = "2023"; - option features.(abc).d_e = deeply_nested_false; - message Message { - oneof SomeOneOf { - option features.json_format = LEGACY_BEST_EFFORT; - int32 a = 13; - string b = 14 [features.json_format = ALLOW]; - } - }`).root.resolveAll(); - test.same(rootEditionsOverriden.lookup("SomeOneOf").fieldsArray.find(x => x.name === 'b')._features, { enum_type: 'OPEN', field_presence: 'EXPLICIT',