Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container.v1 resources not supported #264

Open
vvuk opened this issue Nov 5, 2024 · 1 comment · May be fixed by #265
Open

container.v1 resources not supported #264

vvuk opened this issue Nov 5, 2024 · 1 comment · May be fixed by #265

Comments

@vvuk
Copy link

vvuk commented Nov 5, 2024 •
edited
Loading

🔥 Bug Description

Docker container resources are generated by Aspire as container.v1 now in this commit if they use WithDockerfile. I think this requires either generating a build entry in docker-compose, or actually doing the build as part of the aspirate run; not sure what the equivalent would be in k8s.
@vvuk
Copy link
Author

vvuk commented Nov 5, 2024

I don't actually know why this got added as different than dockerfile.v0 resources -- I think dockerfile.v0 seems to be just the ability to containerize an existing executable.

@vvuk vvuk linked a pull request Nov 5, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hacky container.v1 prototype vvuk/aspirational-manifests
1 participant
@vvuk