From 848d289380a9a0bc8f5a9b24d4136c7750d42a3e Mon Sep 17 00:00:00 2001 From: Jonathan Rochkind Date: Mon, 14 Oct 2024 18:59:46 -0400 Subject: [PATCH] Test with esbuild/propshaft including both Rails 7.2 and 8.0 --- .github/workflows/ruby.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 8cffba414..39d593ef9 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -34,6 +34,7 @@ jobs: runs-on: ubuntu-latest name: test (ruby ${{ matrix.ruby }} / rails ${{ matrix.rails_version }} ${{ matrix.additional_name }}) strategy: + fail-fast: false matrix: ruby: ["3.3"] rails_version: ["7.0.8.4", "7.1.3.4", "7.2.0"] @@ -46,6 +47,10 @@ jobs: - ruby: "3.3" rails_version: "8.0.0.beta1" additional_engine_cart_rails_options: --css=bootstrap + - ruby: "3.3" + rails_version: "8.0.0.beta1" + additional_engine_cart_rails_options: --css=bootstrap --js=esbuild + additional_name: "/ esbuild" - ruby: "3.2" rails_version: "7.0.8.4" - ruby: "3.2" @@ -63,6 +68,10 @@ jobs: api: "true" additional_engine_cart_rails_options: --api --skip-yarn additional_name: "/ API" + - ruby: "3.3" + rails_version: "7.2.1" + additional_engine_cart_rails_options: -a propshaft --css=bootstrap --js=esbuild + additional_name: "/ Propshaft, esbuild" env: RAILS_VERSION: ${{ matrix.rails_version }} SOLR_VERSION: ${{ matrix.solr_version || 'latest' }}