Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow presetPath to contain a name of the file #54

Open
tari3x opened this issue Feb 18, 2023 · 3 comments
Open

Allow presetPath to contain a name of the file #54

tari3x opened this issue Feb 18, 2023 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@tari3x
Copy link

tari3x commented Feb 18, 2023

In a somewhat recent version of the UI I was able to submit a preset filename as presetPath which would open the given preset. In the current tip this results in a crash, Is there some other way to just load a specific preset?

 /home/avatar/bin/projectMSDL.exe --presetPath="./Fractal/Nested Circle/LuX - Heavy Acid Trip 3.milk" 
Recording audio from device "Default capturing device" (ID -1).
Opened audio recording device "System default capturing device" (ID -1) with 2 channels at 44100 Hz.
Null pointer: path in file "./Foundation/src/Path.cpp", line 64
@tari3x
Copy link
Author

tari3x commented Feb 18, 2023

To be more precise, pressing "r" does nothing and pressing space results in the crash.

@kblaschke kblaschke added the bug Something isn't working label Feb 22, 2023
@kblaschke
Copy link
Member

While it should not crash (will fix that), the presetPath option currently doesn't support single files, as it's interpreted as a directory.

Absolutely makes sense to check if the given path is a file or directory and add it accordingly, will put it on the to-do list.

Plus, in the currently WIP UI overhaul, it'll be possible to create individual playlists containing any number of preset files in a specific order and also load a playlist on startup.

@kblaschke kblaschke added the enhancement New feature or request label Feb 22, 2023
@tari3x
Copy link
Author

tari3x commented Mar 1, 2023

Thanks!

It definitely used to work, even if not intentionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants