-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sync): add tag excludeRegex filter #2906
Conversation
f618593
to
9be3b6e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2906 +/- ##
==========================================
- Coverage 91.89% 91.86% -0.03%
==========================================
Files 170 170
Lines 30291 30323 +32
==========================================
+ Hits 27836 27857 +21
- Misses 1827 1836 +9
- Partials 628 630 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would also add an example under examples/
@vooon For your particular use case, are you sure there is no workaround that can avoid this PR altogether.
@rchincha well, there are workaround, negate every character of the word: But that very soon will remind me famous perl test-test-test... :) |
Fix project-zot#2902 Signed-off-by: Vladimir Ermakov <[email protected]>
9be3b6e
to
26b4122
Compare
What happens if both "regex" and "excludeRegex" are specified? and they step on each other? |
@rchincha regex first select tags, then excludeRegrex filter-out matching tags from that list. |
Isn't it the same result if you have the following ops on sets of tags:
|
@andaaron yes, all of that cases gives the same result. But the code more like that:
|
What type of PR is this?
feature
Which issue does this PR fix:
Fix #2902
What does this PR do / Why do we need it:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.