Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CH-EMED-EPR: use stable Format, Type and Class codes instead of beta #179

Open
qligier opened this issue Sep 19, 2024 · 5 comments
Open
Assignees
Labels
bug Something isn't working work-in-progress

Comments

@qligier
Copy link
Member

qligier commented Sep 19, 2024

In , we use enums from the beta package instead of stable ones:

import org.projecthusky.communication.ch.enums.beta.ClassCode;
import org.projecthusky.communication.ch.enums.beta.FormatCode;
import org.projecthusky.communication.ch.enums.beta.TypeCode;

The beta enums have not been updated and contain some wrong values.
At least the FormatCodes have changed, the year in them was updated.

CH_EMED_MEDICATION_TREATMENT_PLAN_DOCUMENT("urn:che:epr:ch-emed:mtp:2024",

@qligier qligier added the bug Something isn't working label Sep 19, 2024
@qligier qligier changed the title CH-EMED-EPR: use current Format, Type and Class codes instead of beta CH-EMED-EPR: use stable Format, Type and Class codes instead of beta Sep 19, 2024
@dvribeira
Copy link
Collaborator

dvribeira commented Oct 17, 2024

Is it acceptable to do this as part of the updates to be done with the release of CH EMED EPR 2.0.0? That way all the systems can address this along with any other breaking changes in a hopefully somewhat synchronised manner.

@dvribeira
Copy link
Collaborator

CH_EMED_MEDICATION_CARD_DOCUMENT("urn:che:epr:ch-emed:medication-card:2022",
needs to be fixed since it should be "urn:che:epr:ch-emed:medication-card:2023" according to annex 3 EPRO-FDHA. It seems to be a fix added on art-decor after initial publication: https://ehealthsuisse.art-decor.org/ch-epr-html-20241120T102212/project.html

I guess the enums should be re-generated form the latest art-decor?

@dvribeira dvribeira self-assigned this Jan 14, 2025
dvribeira added a commit that referenced this issue Jan 14, 2025
…lassCode, FormatCode and TypeCode enums (update to version 6 of Annex 3).
@dvribeira
Copy link
Collaborator

CH_EMED_MEDICATION_CARD_DOCUMENT("urn:che:epr:ch-emed:medication-card:2022",

needs to be fixed since it should be "urn:che:epr:ch-emed:medication-card:2023" according to annex 3 EPRO-FDHA. It seems to be a fix added on art-decor after initial publication: https://ehealthsuisse.art-decor.org/ch-epr-html-20241120T102212/project.html

I guess the enums should be re-generated form the latest art-decor?

Created new issue for this: #218

@dvribeira
Copy link
Collaborator

dvribeira commented Jan 14, 2025

The stable format codes do not have an entry for the APPC. This is not used within Husky, but for instance the PMP aggregator did rely on it. Since the enum is supposed to contain only the format codes sanctioned by the Annex 3 of the EPR regulations, this format code should be placed somewhere else. However, Husky does not deal at all in general with APPC so I wonder whether we need the format code for the APPC to be coded anywhere within Husky at all. @qligier do you have a use for it within Husky or an opinion on that regard?

@qligier
Copy link
Member Author

qligier commented Jan 14, 2025

I don't have any use for it currently. The main need was from the aggregator, and we may want to have it somewhere in Husky for the future implementers, but we should definitively split it from the EPR parts.

dvribeira added a commit that referenced this issue Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working work-in-progress
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants