Skip to content
This repository has been archived by the owner on Jan 17, 2025. It is now read-only.

[REFACTOR] Happy Path: use the CSSStyleSheet API to create CSS rule #40

Open
tbouffard opened this issue Oct 12, 2022 · 0 comments
Open

[REFACTOR] Happy Path: use the CSSStyleSheet API to create CSS rule #40

tbouffard opened this issue Oct 12, 2022 · 0 comments

Comments

@tbouffard
Copy link
Member

Note: not needed if we implement #39

Currently, for the happy-path use case, we add a lot of CSS rules with JS code by directly updating the head HTML element in the DOM.
We could instead create the rules using the CSSStyleSheet.insertRule API.

https://github.com/assynour/icpm-demo-2022/blob/aef4e01609ccd557a5e8fd615fd4112889ae3e47/src/happy-path.js#L80-L89
@tbouffard tbouffard changed the title [REFACTOR] Use the CSSStyleSheet API to create CSS rule in the happy-path use case [REFACTOR] Happy Path: use the CSSStyleSheet API to create CSS rule Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbouffard