-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for query strings #1730
Comments
A good practical use case might be a static web site built with jekyll. I am however a bit concerned that there is a slippery slope here. If the goal is really "interop with Chrome", we need a couple of other works:
|
And then we have to consider support for let's encrypt/ACME. |
Ok, I haven't looked into the POST & CONNECT part yet. But I think everything we need to handle query strings, is already implemented in
In my case, I process the query string only on the client side. For me, it would be enough to recognize & skip the query string part for GET requests. I don't want to work with the query string on the server side. But the h3zero_server_parse_path() function fails to find the requested file with the query string at the end of the path. Of course, we can also put more effort into this.
Yes, I don't want to implement a fully fledged web server. I think there is a lot of work to do so. Currently it works fine to start Chrome with the
Maybe it would be an idea to start a separate process on port 80/443 to simply say: "Hey, there's a QUIC website. (alt-svc)". And then redirect to it. However, I don't have much experience with how this HTTP -> HTTP3 upgrade process works in different browsers.
You are talking about the HTTP-01 challenge, right? The HTTP-01 challenge requires you to open port 80. Which brings us back to run as root. This whole discussion tends to: "Shall we make a fully-fledged web server out of h3zero?" Unfortunately, I don't know what the intention behind h3zero was. But I don't think it should be a production-ready web server. |
In a comment to PR #1729 @hfstco observes that h3zero does not currently support query strings. It actually does, but only for POST and CONNECT commands, for which we have an extension mechanism. It would be possible to use the same extension mechanism for GET commands: recognize that the
path-abempty
component of the URL, compare against the table of registered components currently used for POST and CONNECT, and treat a GET to a recognized value pretty much the same way we treat POST.The challenge is to do that while keeping the spirit of h3zero: as small as possible, as simple as possible...
The text was updated successfully, but these errors were encountered: