Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Add unit tests to LookupBuilder #93

Closed
leolara opened this issue Aug 23, 2023 · 10 comments
Closed

Add unit tests to LookupBuilder #93

leolara opened this issue Aug 23, 2023 · 10 comments
Assignees
@motemotech
Labels
gfi easy Easy good first issue good first issue Good for newcomers

Comments

@leolara
Copy link
Collaborator

leolara commented Aug 23, 2023

To structs in this file: https://github.com/privacy-scaling-explorations/chiquito/blob/main/src/frontend/dsl/lb.rs
@leolara leolara added good first issue Good for newcomers gfi easy Easy good first issue labels Aug 23, 2023
@gnart33 gnart33 self-assigned this Aug 23, 2023
@motemotech
Copy link

Hi, can I work on this issue?

@qwang98
Copy link
Collaborator

qwang98 commented Sep 11, 2023

@trangnv Still on this?

@gnart33
Copy link
Contributor

gnart33 commented Sep 11, 2023

@motemotech Yes you can work on this!

@leolara leolara assigned motemotech and unassigned gnart33 Sep 13, 2023
@motemotech
Copy link

Hi, do you have any naming rules for branchs in this prj?

@leolara
Copy link
Collaborator Author

leolara commented Sep 19, 2023

@motemotech not really rules but we usually do githandle/something-meaningfull

@motemotech
Copy link

ok, gotcha.

@motemotech
Copy link

@leolara
Hi, I finally finished adding test, but seems I do not have permission to push my branch.
Could you add me as a member of this repository?

@leolara
Copy link
Collaborator Author

leolara commented Oct 2, 2023

You have to create a branch in your fork, and then submit a PR @motemotech

@motemotech
Copy link

@leolara
Hi! Sorry for being late.
Is this good?
#148

@leolara
Copy link
Collaborator Author

leolara commented Feb 20, 2024

@motemotech the PR has unsolved problems

@leolara leolara moved this to In review in Chiquito 2024 Feb 20, 2024
@leolara leolara closed this as completed Aug 28, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Chiquito 2024 Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@motemotech motemotech

Labels
gfi easy Easy good first issue good first issue Good for newcomers
Projects
Chiquito 2024
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@leolara @gnart33 @motemotech @qwang98