-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #7593: disableKeyboardNavigation prop for Tree component #7588
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
I am not sure why you would want this as PrimeReact aims to be WCAG/ARIA compliant for components this essentially turns that off so I am |
For example, I'm working on using the component where you can change the name of a node thanks to an input texte that appears in place of the node name. So i want to deactivate temporarily the key navigation. For WCAG/ARIA, it is only a property manually assigned by the developer (and I think it's good to give the developer the freedom to decide where to apply the WCAG/ARIA principles) |
OK if that is your use case then you should check const isInputTarget= (event) => {
return event.currentTarget.matches('input, select');
}; If so then in the |
also please open a ticket first with your scenario. |
Ok thank you very much I didn't know this at all, I'm trying this afternoon. I quickly open a ticket |
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>. |
Fix #7593: disableKeyboardNavigation prop for Tree component
[Small feature]
Added a "keyboardKeyboardNavigation" to prevent expansion and collapse with arrow keys, and all key navigation (enter, tab, space, arrows)